Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Adds the drag icon #16919

Merged
merged 1 commit into from
Sep 30, 2021
Merged

chore: Adds the drag icon #16919

merged 1 commit into from
Sep 30, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds the drag icon.

@m-ajay @graceguo-supercat @junlincc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-09-30 at 10 01 57 AM

TESTING INSTRUCTIONS

Check the new icon in the Storybook.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina mentioned this pull request Sep 30, 2021
Merged
8 tasks
villebro
villebro approved these changes Sep 30, 2021
View reviewed changes
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looking forward to seeinf this start getting used

@codecov
Copy link

codecov bot commented Sep 30, 2021

Codecov Report

Merging #16919 (6c5470a) into master (ae26967) will decrease coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16919      +/-   ##
==========================================
- Coverage   76.77%   76.75%   -0.03%     
==========================================
  Files        1022     1022              
  Lines       54884    54884              
  Branches     7483     7483              
==========================================
- Hits        42137    42126      -11     
- Misses      12499    12510      +11     
  Partials      248      248
Flag Coverage Δ
javascript 71.02% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Icons/index.tsx 100.00% <ø> (ø)
...ersConfigModal/FiltersConfigForm/DatasetSelect.tsx 48.48% <0.00%> (-36.37%) ⬇️
...d/src/filters/components/Time/TimeFilterPlugin.tsx 86.66% <0.00%> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 73.83% <0.00%> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 89.42% <0.00%> (+0.96%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae26967...6c5470a. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 1a38ec6 into apache:master Sep 30, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@michael-s-molina
chore: Adds the drag icon (apache#16919)
b1b52cc
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@michael-s-molina
chore: Adds the drag icon (apache#16919)
adcb68b
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@villebro villebro villebro approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @villebro @mistercrunch